Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String: Increase prefix size from 128 to 256 chars #1779

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

kevsecurity
Copy link
Contributor

The file prefix limit was originally 256 characters. When the code was converted to use LMP TRIE maps, the limit was set to 128 characters.

This commit changes the prefix limit from 128 to 256 characters.

Increases the character limit for prefix matches from 128 to 256.

The file prefix limit was originally 256 characters. When the code was
converted to use LMP TRIE maps, the limit was set to 128 characters.

This commit changes the prefix limit from 128 to 256 characters.

Signed-off-by: Kevin Sheldrake <[email protected]>
@kevsecurity kevsecurity added the release-note/minor This PR introduces a minor user-visible change label Nov 21, 2023
@kevsecurity kevsecurity requested a review from a team as a code owner November 21, 2023 18:45
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's correct

@kevsecurity kevsecurity merged commit fa29d2a into main Nov 22, 2023
32 checks passed
@kevsecurity kevsecurity deleted the pr/kevsecurity/increase-prefix-to-256 branch November 22, 2023 13:41
@mtardy
Copy link
Member

mtardy commented Nov 24, 2023

I got raced 🏎️ c02af3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants