backports/v1.0: fieldfilters: fix regression with missing top-level info and add test #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream commit 651fcf1] We had a regression after some fieldfilter bug fixes and performance optimizations that caused top-level information to be missing from events when field filters are applied. The fix here is to make sure that we are setting non-event fields in the destination struct. Apply the fix and add a unit test to check for future regressions. Signed-off-by: William Findlay <[email protected]>
willfindlay
added
the
release-note/bug
lambdanis
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[upstream commit 651fcf1]
We had a regression after some fieldfilter bug fixes and performance optimizations that caused top-level information to be missing from events when field filters are applied. The fix here is to make sure that we are setting non-event fields in the destination struct. Apply the fix and add a unit test to check for future regressions.
Backport of #1882.