Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing Printer to GoldenCodecTests #57

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

fredfp
Copy link
Contributor

@fredfp fredfp commented Jun 26, 2020

ref: #56

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #57 into master will decrease coverage by 0.75%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   80.00%   79.24%   -0.76%     
==========================================
  Files           6        6              
  Lines         105      106       +1     
==========================================
  Hits           84       84              
- Misses         21       22       +1     
Impacted Files Coverage Δ
...cala/io/circe/testing/golden/GoldenCodecLaws.scala 80.00% <50.00%> (-8.89%) ⬇️
...ala/io/circe/testing/golden/GoldenCodecTests.scala 58.82% <75.00%> (-1.18%) ⬇️
...e/testing/golden/ResourceFileGoldenCodecLaws.scala 46.66% <100.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8030252...e864b10. Read the comment docs.

@fredfp
Copy link
Contributor Author

fredfp commented Jun 26, 2020

I did something quickly, I'm not sure what's best to deal with the optional/default parameters here, let me know what your thoughts are.

I have no good ideas to improve the code coverage situation, just a few ideas of how to work around that. What are you expecting?

@travisbrown
Copy link
Member

This looks reasonable to me, and the slight code coverage drop isn't a big deal. I'll try to take a closer look and get it merged this weekend.

@travisbrown
Copy link
Member

Also thanks!

@fredfp
Copy link
Contributor Author

fredfp commented Jul 1, 2020

Hello @travisbrown , do you have any feedback or doubts?

I'd love to move forward with that as it'll make implementation of circe-golden much easier in some of our bigger projects

@travisbrown
Copy link
Member

@fredfp The one thing I still wanted to look at is making sbt mimaReportBinaryIssues pass, so that we don't need to bump the minor version, but I don't think that's a big deal, and will go ahead and merge.

@travisbrown travisbrown merged commit 1f088c1 into circe:master Jul 1, 2020
@fredfp
Copy link
Contributor Author

fredfp commented Jul 1, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants