remove implementation details, make accurate with new remote docker arch #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
DominicLavery
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
This is totally an improvement and happy for it to be merged as is.
The "different location" statement could maybe be improved. I'm thinking the location of the daemon is the implementation detail. The fact that a job is executed in a container that has access to a daemon is the feature.
So something along the lines of
A jobs commands are executed in a container that has access to an external docker daemon, so whilst using docker CLI or compose you must move data around...
|
@DominicLavery thanks, made some slight changes. let me know what you think |
|
LGTM |
|
@rosieyohannan can you take a peek when you get a chance please 🙏 thanks! |
rosieyohannan
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tries to remove some (i think unecessary) implementation details about how our system works. also tries to remove references to the word "remote" since that's a bit of a relic from a previous architecture.
that being said, it keeps the bulk of the content in place because the workarounds described are still needed when using remote docker even with the new architecture