Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STABLE-3917] Add instruction docs to README #9

Merged
merged 4 commits into from
Jun 26, 2023
Merged

[STABLE-3917] Add instruction docs to README #9

merged 4 commits into from
Jun 26, 2023

Conversation

davidyu-circle
Copy link
Contributor

@davidyu-circle davidyu-circle commented Jun 26, 2023

Summary

Add instructions in README on how to add support for a new chain.

Detail

  • Renamed addresses file for easier change
  • Added section on adding new chain

Testing

Mostly adding documentation but tested simply E2E flow from ETH -> AVAX

Documentation

  • Updated README

Requested Reviewers: @mention

@davidyu-circle davidyu-circle changed the title Rename addressees constants [STABLE-3917] Rename addressees constants Jun 26, 2023
@davidyu-circle davidyu-circle changed the title [STABLE-3917] Rename addressees constants [STABLE-3917] Add instruction docs to README Jun 26, 2023
Copy link

@zhenghui-w zhenghui-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the instructions, following the code, makes sense to me; thanks!

@davidyu-circle davidyu-circle merged commit bad7956 into circlefin:master Jun 26, 2023
@davidyu-circle davidyu-circle deleted the readme branch June 26, 2023 20:26
davidyu-circle added a commit to davidyu-circle/cctp-sample-app that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants