Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pdf order and more by using natural sort instead of python sort #589

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix pdf order and more by using natural sort instead of python sort #589

merged 2 commits into from
Nov 9, 2023

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Sep 8, 2023 •
edited
Loading

Prebuilt binaries for download for normal user testing:

So that's why we did number padding in the old sort method.

@darodi
Copy link
Collaborator

darodi commented Sep 8, 2023

Thanks @axu2
I'll adapt dockers and such before merging this.

@axu2 axu2 changed the title use natural sort use natural sort instead of python sort Sep 16, 2023
@axu2 axu2 changed the title use natural sort instead of python sort use natural sort instead of python sort (fixes pdf order) Oct 2, 2023
@axu2 axu2 changed the title use natural sort instead of python sort (fixes pdf order) fix pdf order by using natural sort instead of python sort Oct 2, 2023
@axu2 axu2 changed the title fix pdf order by using natural sort instead of python sort fix page order by using natural sort instead of python sort Oct 2, 2023
@axu2 axu2 changed the title fix page order by using natural sort instead of python sort fix page order in pdf and more by using natural sort instead of python sort Oct 2, 2023
@darodi darodi self-requested a review October 26, 2023 19:17
@elliopitas
Copy link

had problems with page number and this fixed it

@axu2
Copy link
Collaborator Author

axu2 commented Oct 30, 2023

@darodi could we get a mini-release with this fix included?

@darodi
Copy link
Collaborator

darodi commented Nov 9, 2023

merging this.
I'll test docker build later and create a PR at that moment if this is needed

@darodi darodi merged commit 68da853 into ciromattia:master Nov 9, 2023
@darodi darodi added this to the 5.6.4 milestone Nov 9, 2023
@axu2 axu2 deleted the natsort branch November 9, 2023 23:33
@axu2 axu2 changed the title fix page order in pdf and more by using natural sort instead of python sort fix pdf order and more by using natural sort instead of python sort Nov 25, 2023
@axu2 axu2 mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darodi darodi Awaiting requested review from darodi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.4
Development

Successfully merging this pull request may close these issues.

Images showing up in wrong order Conversion Issue: Pages out of order
3 participants
@axu2 @darodi @elliopitas