reduce dependency on 7z, unar, homebrew by using builtin tar #693
+26
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tar is an incredibly powerful decompression tool that even supports rar.
It has been in macOS since 2009. And was added to Windows 10 in 2017. It's probably in every linux distro.
https://github.com/libarchive/libarchive/wiki/LibarchiveUsers#apple-macos
https://devblogs.microsoft.com/commandline/tar-and-curl-come-to-windows/
This way, users don't need to install homebrew and xcode on macOS to use it unless they also want metadata editing. Same for Windows.
Also, tar seems faster than 7z!
Test builds: https://github.com/axu2/kcc/releases/tag/v6.0.0-tar
@AlicesReflexion @cookie99999 @darodi Do you think unrar is still needed on fedora?
Related:
Feel free to test: @thevenomsnake @shihong5858 @AdrianJesusSilva