-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure all conn.log entries are tagged "ics" for OT protocols #541
Labels
enhancement
New feature or request
ics
Relating to ICS (Industrial Control Systems) devices
logstash
Relating to Malcolm's use of Logstash
zeek
Relating to Malcolm's use of Zeek
Milestone
Comments
mmguero
added
enhancement
New feature or request
logstash
Relating to Malcolm's use of Logstash
zeek
Relating to Malcolm's use of Zeek
labels
Dec 19, 2024
mmguero
added a commit
to mmguero-dev/Malcolm
that referenced
this issue
Jan 9, 2025
…ices.log get the ICS protocols assigned to them corrrectly and tagged appropriately
I've made some tweaks made so far to make sure the service gets normalized correctly for conn.log and known_services.log. Also, still need to check:
|
mmguero
added a commit
to mmguero-dev/Malcolm
that referenced
this issue
Jan 9, 2025
mmguero
added a commit
to mmguero-dev/Malcolm
that referenced
this issue
Jan 9, 2025
…tagged with 'ics' properly cisagov#541
From what I can see now, all appropriate conn.log entries are being tagged with |
This was referenced Jan 17, 2025
Merged
mmguero
added a commit
to idaholab/Malcolm
that referenced
this issue
Jan 17, 2025
…ices.log get the ICS protocols assigned to them corrrectly and tagged appropriately
mmguero
added a commit
to idaholab/Malcolm
that referenced
this issue
Jan 17, 2025
mmguero
added a commit
to idaholab/Malcolm
that referenced
this issue
Jan 17, 2025
…tagged with 'ics' properly cisagov#541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
ics
Relating to ICS (Industrial Control Systems) devices
logstash
Relating to Malcolm's use of Logstash
zeek
Relating to Malcolm's use of Zeek
We need to make sure that all conn.log entries get tagged with
ics
when an ICS protocol is detected.This is maybe already supposed to be handled but I don't see it is being done in every case. I wonder if it's actually an issue in the parsers. Some of them seem to be setting the service correctly (bacnet, s7comm) but I don't think that all of them.
So here's what needs to happen:
service
to the protocol name; if not, this will have to be submitted as a PR to that repositoryics
value into thetags
fieldThe text was updated successfully, but these errors were encountered: