Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate documentUrl Building Into a Single Service #3678

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

Marcus-Goectau
Copy link
Member

🗣 Description

We were repeating the same document URL building functionality across several components. These changes consolidate the behavior into a shared method within the ReourceLibraryService.

💭 Motivation and context

Easier to maintain code by using a single, shared service for document URL building behavior. This ensures we have consistent behavior across the application.

🧪 Testing

Tested locally to ensure reference document behavior remained the same.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@randywoods randywoods merged commit b5e1be5 into develop Dec 18, 2023
2 checks passed
@randywoods randywoods deleted the feature/CSET-2500 branch December 18, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants