Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildkit for use with new site_email_address table #911

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Feb 6, 2025

This complements civicrm/civicrm-core#31909 by installing site email in the appropriate table depending on version.

@colemanw colemanw changed the title Update buildkit for use with new domain_email_address table Update buildkit for use with new site_email_address table Feb 7, 2025
@@ -20,7 +20,7 @@ backdrop_install
## Setup CiviCRM (config files, database tables)

CIVI_DOMAIN_NAME="Demonstrators Anonymous"
CIVI_DOMAIN_EMAIL="\"Demonstrators Anonymous\" <[email protected]>"
CIVI_DOMAIN_EMAIL="[email protected]"
Copy link
Member

@totten totten Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little torn. The above would be fine greenfield-wise, and it's written/tested. OTOH, I try to keep env-vars pretty stable for anyone who has a fork with their own build-type. OTOOH, this isn't a contract that we're vocal about.

The underlying issue is probably that this kind of value pushes the limits of what's intuitive/safe for processing with shell commands. (Actually, cv sql --eval has a better notation @ENV[XXX], but api3/api4 don't have an equivalent -- and api3/api4 seems seems like a nicer bridge -- eg when faced with git bisect, cv api4 OptionValue.update would endure better.)

I think I'll go ahead and merge this to keep 31909 moving. But I reserve the right to flipflop 😉 (if I find a nicer way to switch it to api4).

@totten totten merged commit 8f96dee into civicrm:master Feb 7, 2025
@colemanw colemanw deleted the domainEmailAddress branch February 7, 2025 10:49
@colemanw
Copy link
Member Author

colemanw commented Feb 7, 2025

@totten so you're saying there might be build types floating around with CIVI_DOMAIN_EMAIL="Demonstrators Anonymous" <[email protected]>?

What about just add a little regex here to extract the email part from the angle brackets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants