improve error message consistency #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulviodenza
reviewed
Oct 21, 2024
| @@ -325,16 +325,16 @@ func decodeError(err error) error { | |||
| switch err := err.(type) { | |||
| case *url.Error: | |||
| if _, ok := err.Err.(net.Error); ok { | |||
| err := fmt.Errorf("we found a problem connected against the api") | |||
| err := fmt.Errorf("problem connecting to the API") | |||
There was a problem hiding this comment.
we could return also the error to be more descriptive and allow the user to debug more precisely, what do you think?
this is valid for all the errors in the PR
There was a problem hiding this comment.
I think we need to implement a global flag --debug and if that is true we can show more verbose errors
There was a problem hiding this comment.
I'm not against having a flag or more descriptive errors overall, but just raised this because during a connection problem I noticed the language currently isn't especially clear.
There was a problem hiding this comment.
I'm ok with this one, we can put the flag for feature versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the grammar and consistency of a few error messages