Fixed error in the provider

Fixed error i the volume resource
Add the test for the volume

Signed-off-by: Alejandro JNM <[email protected]>

civo/resource_volume.go

@@ -65,7 +65,7 @@ func resourceVolumeCreate(d *schema.ResourceData, m interface{}) error {
 
 	d.SetId(volume.ID)
 
-	return resourceNetworkRead(d, m)
+	return resourceVolumeRead(d, m)
 }
 
 // function to read the volume

civo/resource_volume_test.go

@@ -0,0 +1,154 @@
+package civo
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/civo/civogo"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/terraform"
+)
+
+// example.Widget represents a concrete Go type that represents an API resource
+func TestAccCivoVolume_basic(t *testing.T) {
+	var volume civogo.Volume
+
+	// generate a random name for each test run
+	resName := "civo_volume.foobar"
+	var VolumeName = acctest.RandomWithPrefix("tf-test")
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckCivoVolumeDestroy,
+		Steps: []resource.TestStep{
+			{
+				// use a dynamic configuration with the random name from above
+				Config: testAccCheckCivoVolumeConfigBasic(VolumeName),
+				// compose a basic test, checking both remote and local values
+				Check: resource.ComposeTestCheckFunc(
+					// query the API to retrieve the widget object
+					testAccCheckCivoVolumeResourceExists(resName, &volume),
+					// verify remote values
+					testAccCheckCivoVolumeValues(&volume, VolumeName),
+					// verify local values
+					resource.TestCheckResourceAttr(resName, "name", VolumeName),
+					resource.TestCheckResourceAttr(resName, "size_gb", "60"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccCivoVolume_update(t *testing.T) {
+	var volume civogo.Volume
+
+	// generate a random name for each test run
+	resName := "civo_volume.foobar"
+	var VolumeName = acctest.RandomWithPrefix("tf-test")
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckCivoVolumeDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCheckCivoVolumeConfigBasic(VolumeName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckCivoVolumeResourceExists(resName, &volume),
+					testAccCheckCivoVolumeValues(&volume, VolumeName),
+					resource.TestCheckResourceAttr(resName, "name", VolumeName),
+					resource.TestCheckResourceAttr(resName, "size_gb", "60"),
+				),
+			},
+			{
+				// use a dynamic configuration with the random name from above
+				Config: testAccCheckCivoVolumeConfigUpdates(VolumeName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckCivoVolumeResourceExists(resName, &volume),
+					testAccCheckCivoVolumeUpdated(&volume, VolumeName),
+					resource.TestCheckResourceAttr(resName, "name", VolumeName),
+					resource.TestCheckResourceAttr(resName, "size_gb", "80"),
+				),
+			},
+		},
+	})
+}
+
+func testAccCheckCivoVolumeValues(volume *civogo.Volume, name string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		if volume.Name != name {
+			return fmt.Errorf("bad name, expected \"%s\", got: %#v", name, volume.Name)
+		}
+		return nil
+	}
+}
+
+// testAccCheckExampleResourceExists queries the API and retrieves the matching Widget.
+func testAccCheckCivoVolumeResourceExists(n string, volume *civogo.Volume) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		// find the corresponding state object
+		rs, ok := s.RootModule().Resources[n]
+		if !ok {
+			return fmt.Errorf("Not found: %s", n)
+		}
+
+		// retrieve the configured client from the test setup
+		client := testAccProvider.Meta().(*civogo.Client)
+		resp, err := client.FindVolume(rs.Primary.ID)
+		if err != nil {
+			return fmt.Errorf("Volume not found: (%s) %s", rs.Primary.ID, err)
+		}
+
+		// If no error, assign the response Widget attribute to the widget pointer
+		*volume = *resp
+
+		// return fmt.Errorf("Domain (%s) not found", rs.Primary.ID)
+		return nil
+	}
+}
+
+func testAccCheckCivoVolumeUpdated(volume *civogo.Volume, name string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		if volume.Name != name {
+			return fmt.Errorf("bad name, expected \"%s\", got: %#v", name, volume.Name)
+		}
+		return nil
+	}
+}
+
+func testAccCheckCivoVolumeDestroy(s *terraform.State) error {
+	client := testAccProvider.Meta().(*civogo.Client)
+
+	for _, rs := range s.RootModule().Resources {
+		if rs.Type != "civo_volume" {
+			continue
+		}
+
+		_, err := client.FindVolume(rs.Primary.ID)
+		if err == nil {
+			return fmt.Errorf("Volume still exists")
+		}
+	}
+
+	return nil
+}
+
+func testAccCheckCivoVolumeConfigBasic(name string) string {
+	return fmt.Sprintf(`
+resource "civo_volume" "foobar" {
+	name = "%s"
+	size_gb = 60
+	bootable = false
+}`, name)
+}
+
+func testAccCheckCivoVolumeConfigUpdates(name string) string {
+	return fmt.Sprintf(`
+resource "civo_volume" "foobar" {
+	name = "%s"
+	size_gb = 80
+	bootable = false
+}`, name)
+}