Added the egress rules and create_default_rules option to firewall #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault rules when you create a firewall Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
RealHarshThakur
approved these changes
Feb 16, 2022
|
We should probably bump up the go version in github action to match the one in go.mod |
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
|
@RealHarshThakur Done |
.github/workflows/go.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| go-version: [1.14.x, 1.15.x, 1.16.x, 1.17.x] |
There was a problem hiding this comment.
I don't think we need to test all versions with GHA. Just the one we are using for this provider. It's because there's no client/other package depending on this
There was a problem hiding this comment.
I will keep this [1.16.x, 1.17.x]
|
Seems like the build is failing from 1.16? |
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the egress rules and the option to avoid the creation of the default rules when you create a firewall