Added resource & data source for object store credentials #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but we need test this, we need wait for this feature in production or staging or have the same in the KubeFake |
Yes @alejandrojnm. Testing is still pending. I and @haardikdharma10 will test it with your assistance. |
Signed-off-by: satakshigarg <[email protected]> Added updated go.mod files Signed-off-by: satakshigarg <[email protected]>
satakshigarg
force-pushed
the
Terraform_Object_Store_Cred
branch
from
86094f9 to
9c17c4b
Compare
Signed-off-by: satakshigarg <[email protected]>
… API Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
RealHarshThakur
approved these changes
Sep 14, 2022
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Terraform resources and data sources for object store credentials and their test files.
Signed-off-by: satakshigarg [email protected]