Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 'applications' argument's description and corresponding examples. #38

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Fixed 'applications' argument's description and corresponding examples. #38

merged 1 commit into from
Jun 14, 2021

Conversation

hazsetata
Copy link
Contributor

In the civo_kubernetes_cluster's documentation:

  • The example to remove the default Traefik application wouldn't work ("-traefik") because the app names are case sensitive, so it needs to be "-Traefik".
  • I also added a generic mention for case-sensitivity, and a civo CLI example to list the available applications.
  • Also in the HCL example I removed the space after the "," as the application documentation requires it.

I made the doc updates in both the documentation (markdown) file and the provider file (go).

@hazsetata hazsetata requested a review from alejandrojnm as a code owner June 14, 2021 17:58
@alejandrojnm alejandrojnm merged commit 740b968 into civo:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrojnm alejandrojnm Awaiting requested review from alejandrojnm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hazsetata @alejandrojnm