656 nest support #702
656 nest support #702
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| devices = self.thermostat_obj.get_devices() | ||
| print(f"DEBUG: devices = {devices}") | ||
| meta_data = devices[self.zone] | ||
| if parameter is None: |
Check warning
Code scanning / Prospector (reported by Codacy)
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
| print(f"Please go to {authorization_url} and authorize access") | ||
| return input('Enter the full callback URL: ') | ||
|
|
||
| def get_target_zone_id(self, zone=0): |
Check warning
Code scanning / Prospector (reported by Codacy)
Unused argument 'zone' (unused-argument)
| """ | ||
| if val is None: | ||
| raise AttributeError("environment value cannot be none") | ||
| if key is None: |
Check warning
Code scanning / Prospector (reported by Codacy)
Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise)
There was a problem hiding this comment.
Pylint (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
|
||
| # get credentials from file | ||
| self.google_app_credential_file = ".//credentials.json" | ||
| self.access_token_cache_file = ".//token_cache.json" |
Check warning
Code scanning / Bandit (reported by Codacy)
Possible hardcoded password: './/token_cache.json'
There was a problem hiding this comment.
Pylintpython3 (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
resolves #656 |
initial nest thermostat support, not yet functional