Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #839 add vscode and pycharm interactive modes #840

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

cjkrolak
Copy link
Owner

@cjkrolak cjkrolak commented Dec 7, 2024

No description provided.

Copy link

dryrunsecurity bot commented Dec 7, 2024

DryRun Security Summary

The pull request modifies the is_interactive_environment() function in thermostatsupervisor/environment.py to include "python.exe" and "pycharm.exe" as parent processes when determining if the application is running in an interactive environment.

Expand for full summary

Summary:

The code changes in this pull request are related to the is_interactive_environment() function in the thermostatsupervisor/environment.py file. The changes involve expanding the list of parent processes that are considered to be running in an interactive environment, specifically adding "python.exe" and "pycharm.exe" to the list.

From a security perspective, this change does not appear to introduce any significant security concerns. The is_interactive_environment() function is used to determine the type of environment the application is running in, which can be useful for various purposes, such as configuring logging or other environment-specific settings. However, it's important to ensure that the psutil library used by the function is kept up-to-date and that any known vulnerabilities are addressed. Additionally, the function could potentially be extended to include additional checks or heuristics to more accurately determine the type of environment the application is running in.

Files Changed:

  • thermostatsupervisor/environment.py: The changes in this file expand the list of parent processes that are considered to be running in an interactive environment. Specifically, the function now checks if the current process is a child of either "python.exe" or "pycharm.exe" and returns True if so, indicating an interactive environment. This change does not introduce any obvious security concerns, but it's important to ensure that the psutil library used by the function is secure and up-to-date.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@cjkrolak cjkrolak merged commit a433b15 into develop Dec 8, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant