several lint fixes

[cjkrolak]

No description provided.

[dryrunsecurity]

DryRun Security Summary

The code changes encompass improvements to test suites, documentation, and core functionality across multiple files in the "thermostatsupervisor" application, focusing on enhanced readability, maintainability, and error handling without introducing security vulnerabilities.

Expand for full summary

Summary:

The provided code changes cover a variety of updates across multiple files in the thermostatsupervisor application. The changes primarily focus on improving the test suite, enhancing documentation, and addressing minor issues in the core application functionality.

The changes to the test files, such as test_sht31_integration.py and test_blink_integration.py, aim to improve the readability and maintainability of the integration tests by adding detailed docstrings and enhancing the setup procedures. These changes do not introduce any obvious security vulnerabilities, but it's important to ensure that the tests themselves are designed and executed in a secure manner, considering potential security risks that may arise from interactions with external components.

The updates to the configuration file (conf.py) and the utility functions (utilities.py) are also focused on improving the overall code quality and robustness, without introducing any significant security concerns.

The changes to the core application files, such as sht31.py, mmm.py, and sht31_flask_server.py, primarily address error handling, type annotations, and the parsing of sensor data. These changes aim to improve the reliability and maintainability of the application, but they do not appear to introduce any obvious security vulnerabilities.

However, it's important to note that while these changes do not directly introduce security concerns, the application as a whole should be reviewed for potential security risks, such as input validation, authorization, and secure communication with external components.

Files Changed:

• tests/unit_test_common.py: Updates to the unit tests for the FunctionalIntegrationTest and SuperviseIntegrationTest classes, improving readability and maintainability.
• tests/test_blink_integration.py: Improvements to the docstring and setup for the Blink thermostat integration tests.
• conf.py: Changes to the Sphinx documentation configuration file, including updates to the file header, import statements, and copyright information.
• tests/test_sht31_integration.py: Enhancements to the docstring and setup for the SHT31 thermostat integration tests.
• thermostatsupervisor/sht31.py: Improvements to the error handling and retrying logic in the get_metadata function.
• thermostatsupervisor/utilities.py: A change to the is_valid_file() function to return None when the specified file does not exist.
• thermostatsupervisor/mmm.py: Updates to the type annotations for the get_metadata and get_latestdata methods.
• thermostatsupervisor/sht31_flask_server.py: Improvements to the parsing of the wifi signal strength from the iwlist command.

Code Analysis

We ran 9 analyzers against 8 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.