-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PoetrySession public #277
Draft
cjolowicz
wants to merge
18
commits into
main
Choose a base branch
from
poetry-session
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjolowicz
force-pushed
the
poetry-session
branch
2 times, most recently
from
February 13, 2021 14:52
ae4ea7c
to
c5d348a
Compare
cjolowicz
force-pushed
the
poetry-session
branch
2 times, most recently
from
March 13, 2021 22:43
5b001b8
to
eda0ff9
Compare
The annotations future feature is not supported on Python 3.6.
cjolowicz
force-pushed
the
poetry-session
branch
from
March 14, 2021 01:20
eda0ff9
to
1cea032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
PoetrySession
a part of the public API. It also allows passingnox_poetry.Session
to its constructor instead ofnox.Session
. Thesession.poetry
attribute is deprecated in favor of the new access method.There are two reasons why we might want to do this:
Note that the first goal could already be achieved by creating
nox_poetry.Session
explicitly. In that case, functions other thaninstall
would need to be accessed through thepoetry
attribute.About the second point: It's not safe to assume that certain attributes will never be claimed by Nox. Also, any divergence from the Nox API means that this library is not a transparent wrapper for Nox sessions, and is apt to create confusion. Explicit is better than implicit, etc.