[#5727] Fix datapusher trigger in case of resource_update #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changing URL but using new file via API The notify method in the IResourceUrlChange will be triggered only when the URL is changed or if we do the resource update via the API _submit_to_datapusher will not be triggered and cause the old preview to be displayed.
|
Thanks @shubham-mahajan ! Looks good to me :) cc @amercader |
|
@amercader Can we merge this? I think back porting also required for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5727
Proposed fixes:
The notify method in the IResourceUrlChange will be triggered only when the URL is changed or if we do the resource update via the API, _submit_to_datapusher will not be triggered and cause the old preview to be displayed.
To fix that we need to add the
after_updateIResourceController to trigger_submit_to_datapusher.Features:
Please [X] all the boxes above that apply