You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was not expecting, that the dcat plugin would do anything with my theme, but it ended up overriding the names of some attributes on the resources in my theme.
I guess this is a convenience method to display the translated strings for all those that do not use a custom theme. But for those that do, this plugin might break it.
Is there a way to make this behavior optional or to put it in another plugin? What I now ended up doing is overriding the DCATPlugin, but I'm not sure if this is something everybody has to do, that is in a similar situation like me.
The text was updated successfully, but these errors were encountered:
This could definitely be wrapped in a config option switch (ckanext.dcat.translate_keys) that allowed to turn this behaviour off. Happy to take a PR for it @metaodi
metaodi
pushed a commit
to opendata-swiss/ckanext-dcat
that referenced
this issue
Jan 24, 2018
I just traced a bug to the after_show method of the DCATPlugin.
I was not expecting, that the
dcat
plugin would do anything with my theme, but it ended up overriding the names of some attributes on the resources in my theme.E.g. my theme relies on the existence of an attribute named
res.rights
, after activating thedcat
plugin, this attribute is suddenly calledres.Rights
. (orres.download_url
becomesres.Download URL
)I guess this is a convenience method to display the translated strings for all those that do not use a custom theme. But for those that do, this plugin might break it.
Is there a way to make this behavior optional or to put it in another plugin? What I now ended up doing is overriding the DCATPlugin, but I'm not sure if this is something everybody has to do, that is in a similar situation like me.
The text was updated successfully, but these errors were encountered: