Add VCARD.hasURL property parsing/serialization #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changes in the CKAN Docker images (ckan/ckan-docker-base#80) the images run in the test workflows does not use root by default anymore. This is not supported in GitHub Actions so we need to pass `--user root` option to avoid failures. To catch any permissions related issues, we run the `ckan` and `pytest` commands with `sudo -u ckan`
Rdflib 7.1 introduced changes in [date parsing][1] that made some base
profile tests fail. Basically the previous rdflib versions incomplete
dates like
<time:inXSDDateTimeStamp
rdf:datatype="http://www.w3.org/2001/XMLSchema#date">
1904
</time:inXSDDateTimeStamp>
were expanded to `1904-01-01`. Of course this is not a valid date and
should be expressed using `gYear`:
<time:inXSDDateTimeStamp
rdf:datatype="http://www.w3.org/2001/XMLSchema#gYear">
1904
</time:inXSDDateTimeStamp>
and we should be expecting `1904`.
This should play nice with the time properties we are generating in CKAN as
they already handle automatically `gYear`, `gYearMonth`, `date` and
`dateTime`.
Sites importing external DCAT representations that use the wrong
encoding might need to check their parsers.
[1] RDFLib/rdflib#2929
amercader
reviewed
Dec 13, 2024
| @@ -159,17 +159,12 @@ def _read_datasets_from_db(self, guid): | |||
| ''' | |||
| Returns a database result of datasets matching the given guid. | |||
| ''' | |||
| if toolkit.check_ckan_version(max_version="2.11"): | |||
There was a problem hiding this comment.
This was probably changed by mistake
There was a problem hiding this comment.
Unfortunately, when I revert this setting, the pipeline fails. Please refer to the following link for details: https://github.com/ckan/ckanext-dcat/actions/runs/12284575222. The tests seem to fail unexpectedly.
There was a problem hiding this comment.
Maybe something upstream changed?
There was a problem hiding this comment.
My bad, the version check was wrong: 6bcf693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our HealthDCAT-AP work we identified a need to add the URL property to
dcat:contactPoint. It is defined in the VCARD RDF ontology and meant to link to a contact page for example.I cherrypicked another small fix in this branch, which is that the
foaf:mboxproperty does not strip the mailto: prefix, which is consistently stripped in the rest of the CKAN DCAT extension. It made a few of our test cases fail, I'll include those with the HealthDCAT-AP PR.