Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New HealthDCAT-AP profile #326
New HealthDCAT-AP profile #326
Changes from 16 commits
dfbf750
1e7314c
7ba4777
86b85d2
fb6ecc5
899ac2c
221c002
f5b7216
73e4c88
4e78c47
e4bcca7
d90a4c8
4458afe
d9818fa
3f8cd85
4422323
5a6d402
655370b
1140071
fa18da6
9966dd9
30f3bac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the qualified relationships handling (parsing and serializing), and AFAICT there is nothing health specific to it and could be moved to one of the base DCAT AP profiles right? (euro_dcat_ap_scheming.py would be the right place I think as this was added in DCAT 2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing health specific indeed, it's DCAT 2+. I will move it to the generic scheming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to the generic class, but did not have time anymore to add it to the test cases, sorry! It's still covered by HealthDCAT-AP test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like the same logic as the standard
temporal_coverage
handling. If there's no change is best to delete the method to avoid duplication.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same logic (copy-pasted the lines you're mentioning), moved to a separate function instead of inline. I could also split it off to a separate function in that file to avoid duplication?