Python 3 + CKAN 2.9 + Github Actions

[nickumia-reisys]

Only creating to try and spur github actions into ... action?

[nickumia-reisys]

Sorry! This was meant to be a PR into our own fork...

Btw, these tests are to demonstrate that the extension works in CKAN 2.8 and 2.9 😅

[nickumia-reisys]

After talking with my team, we wanted to open this up to see if upstream would like the upgraded tests running in CKAN 2.9. The main extension requires no update, but the tests were upgraded to run with pytests. Please let me know if there's any questions!

[amercader]

We would love some 2.9 tests and GitHub Actions!

We don't want to keep the nose tests and there should be just a test.py file (no tests_2_8_and_above.py). To make sure the same test suite will work across different CKAN versions add a dev-requirements.txt file with pytest-ckan as a requirement (like here) and install them in the workflow. That will install all requirements even in CKAN<2.9.

This PR also includes a lot of files that seem to be project specific. We shouldn't need the .env, docker-compose.yml, Makefile etc files. Github Actions should pull all the images needed, you can check an existing extension for how the test workflow is defined:

https://github.com/ckan/ckanext-dcat/blob/master/.github/workflows/test.yml

[amercader]

To make sure the same test suite will work across different CKAN versions add a dev-requirements.txt file with pytest-ckan as a requirement (like here) and install them in the workflow.

I see now that you do this here. It's still best to put it on dev-requirements.txt so other developers can use it locally

[nickumia-reisys]

@amercader Sorry for the unnaturally long wait, but I updated this PR to address your comments from above. Please let me know if there's more work to do!

The Data.gov team was hoping that okfn would create another PyPI release with this new code as well 🚀

[nickumia-reisys]

Successful Github Actions

[amercader]

This looks great @nickumia-reisys !
Just some minor comments and we are good to go

[nickumia-reisys]

Thanks for the thorough review @amercader! All of your suggestions were well explained and help to get it back to the CKAN standard. I hope I didn't miss anything 🎯

When this does get merged, don't forget to enabled Github Actions for the repo (if they're not already enabled) and the Data.gov team would greatly appreciate if there was a new PyPI release 😄

If it is of any interest to the CKAN team, there is an automated Github Action that publishes packages to PyPI (the only setup required is adding the PyPI token to the Github Secrets). Here's an example: https://github.com/GSA/ckanext-envvars/blob/main/.github/workflows/deploy.yml

[amercader]

@nickumia-reisys thanks, ckanext-envvars==0.0.2 is available on pypi 🚀