ref: Add Dockerfile and Github Actions pipeline #234
Conversation
* ref: Add Dockerfile and Github Actions pipeline * fix: do not use versioning * fix: use the right stage at build time * imp: use python3 official image * fix: add lxml dependency * fix: add g++ for building * fix: add missing libffi * fix: do not add extra users * fix: use the same user as python * ref: use best methods from @kowh-ai and @mbocevski * fix: dockerfile * fix: do not add www-data group as already exists * fix: use alpine as base image instead of python * ref: use three building methods * fix: use the right build test segmentation * fix: more improvements * fix: Do not use healtcheck on dev * fix: use the ckan variables
gustavovalverde
changed the title
|
cc: @kowh-ai this is using a very similar approach to https://github.com/ckan/ckan-docker/blob/master/datapusher/Dockerfile But it's also adding the whole workflow for Github Actions to deploy the images when pushing to master and also when creating a release. I'm not sure if your team is focusing on using Github Registry or DockerHub, but both are configured in the pipeline. |
|
@gustavovalverde check out https://github.com/keitaroinc/docker-ckan for CKAN, datapusher docker images. |
|
Thanks @mbocevski I've seen a few repos that are already building the images, aside from this one you're sharing. But I'm not sure if this is something that's going to be finally merged on each CKAN source code repo: datapusher, CKAN, solr, etc; or if this images are going to be built and pushed to CKAN official accounts. Just to be sure if there's an official roadmap or agreement on how those images are going to be handled; as we're going to deploy this suite on my country government, but we're required to use official sources, that's why I started this PR here. One of my mains concerns is also seeing the use of git sources inside the Dockerfile https://github.com/keitaroinc/docker-ckan/blob/master/images/datapusher/Dockerfile#L10 as this makes me wonder if the Dockerfile won't reside on the original source code anymore. |
|
@gustavovalverde Keitaro has been publishing and maintaining CKAN and CKAN related docker images for over 5 years, we have over 10k docker image pulls for our CKAN docker images. We do use our fork of datapusher due to changes that have not been merged upstream due to datapusher not getting a lot of maintenance time from the core team. My suggestion is to use Keitaro's docker images and feel free to log issues on our repo if you run into any container related issues. We also have a Helm chart for Linux https://github.com/keitaroinc/ckan-helm |
|
Thanks for your answer @mbocevski If you accept PRs on your side, I could also create some issues with their related PRs for the Dockerfiles and pipeline. |
|
Yeah sure |
Fixes #110
Fixes #136
Fixes #163
Closes #210