Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(base): correct data2 serialization #555

Merged
merged 3 commits into from
Sep 17, 2023
Merged

refactor(base): correct data2 serialization #555

merged 3 commits into from
Sep 17, 2023

Conversation

homura
Copy link
Collaborator

@homura homura commented Sep 15, 2023

Description

Fixes #551

This PR has

  • updated the serialization of the data2
  • skipped the e2e test for the light client because the light client is unavailable for CKB2023 now
  • upgraded the CKB node in the e2e test to v0.111.0

How Has This Been Tested?

  • Modified data2 unit test

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Sep 17, 2023 1:12pm

@homura homura requested a review from zhangyouxin September 15, 2023 11:12
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #555 (953518b) into ckb2023 (4d2367a) will decrease coverage by 0.02%.
The diff coverage is 85.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           ckb2023     #555      +/-   ##
===========================================
- Coverage    86.26%   86.25%   -0.02%     
===========================================
  Files          114      114              
  Lines        23109    23121      +12     
  Branches      2298     2299       +1     
===========================================
+ Hits         19934    19942       +8     
- Misses        3133     3137       +4     
  Partials        42       42              
Files Changed Coverage Δ
packages/base/src/blockchain.ts 98.38% <85.00%> (-0.91%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d2367a...953518b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants