Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: update tx_pool_info and get_transaction response #696

Merged
merged 4 commits into from
May 30, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented May 28, 2024

Description

Fixes #561

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit test
  • E2E test

@homura homura requested a review from Keith-CY May 28, 2024 08:43
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview May 28, 2024 9:04am

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 84.57%. Comparing base (40e12a9) to head (1b4a1af).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #696      +/-   ##
===========================================
- Coverage    86.89%   84.57%   -2.32%     
===========================================
  Files          131      131              
  Lines        25343    25360      +17     
  Branches      2744     2602     -142     
===========================================
- Hits         22021    21448     -573     
- Misses        3281     3876     +595     
+ Partials        41       36       -5     
Files Coverage Δ
packages/base/src/api.ts 100.00% <100.00%> (ø)
packages/ckb-indexer/src/transaction_collector.ts 88.17% <100.00%> (+0.04%) ⬆️
packages/rpc/src/resultFormatter.ts 22.51% <40.00%> (-29.21%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e12a9...1b4a1af. Read the comment docs.

@Keith-CY
Copy link
Member

CI failed

@homura
Copy link
Collaborator Author

homura commented May 29, 2024

CI failed

the package rpc uses Jest as the test runner while the other packages use ava. This difference may cause unexpected results in the test report

@homura homura merged commit 84521a5 into develop May 30, 2024
7 of 9 checks passed
@homura homura deleted the rpc-112 branch May 30, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for CKB v0.112.0
2 participants