Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move deprecate p2sh from 0.23 to 0.24 #706

Merged
merged 3 commits into from
Jun 6, 2024
Merged

feat: move deprecate p2sh from 0.23 to 0.24 #706

merged 3 commits into from
Jun 6, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented Jun 6, 2024

Description

This PR reverts #682 because Lumos needs to release the JoyID support in 0.23, but the Omnilock P2SH auth mode is not completely supported yet

Type of change

Please delete options that are not relevant.

  • Other

@homura homura requested review from Keith-CY and twhy June 6, 2024 01:46
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jun 6, 2024 2:28am

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.96%. Comparing base (4110f0d) to head (6e2d129).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #706      +/-   ##
===========================================
+ Coverage    86.92%   87.96%   +1.04%     
===========================================
  Files          131      131              
  Lines        25360    25247     -113     
  Branches      2745     2801      +56     
===========================================
+ Hits         22044    22209     +165     
+ Misses        3276     3003     -273     
+ Partials        40       35       -5     
Files Coverage Δ
packages/common-scripts/src/omnilock.ts 91.00% <100.00%> (+2.38%) ⬆️
packages/common-scripts/src/omnilock-bitcoin.ts 85.58% <90.90%> (+13.23%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4110f0d...6e2d129. Read the comment docs.

@homura
Copy link
Collaborator Author

homura commented Jun 6, 2024

Added a changelog for version 0.23.0-next.1, and the changelog of the revert will be removed from the changeset automatic PR while release 0.23

@homura homura merged commit f3acc1f into develop Jun 6, 2024
9 checks passed
@homura homura changed the title feat: move deprecate p2sh support from 0.23 to 0.24 feat: move deprecate p2sh from 0.23 to 0.24 Jun 6, 2024
@homura homura deleted the prepare-0.23 branch June 6, 2024 02:40
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
@homura homura mentioned this pull request Jun 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants