Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension-chrome): Use Chrome extension favicon API for whitelist and grant #122

Merged
merged 11 commits into from
Mar 28, 2023

Conversation

IronLu233
Copy link
Contributor

@IronLu233 IronLu233 commented Mar 13, 2023

Resolve #148

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #122 (9e02c22) into main (d72817b) will not change coverage.
The diff coverage is 66.66%.

❗ Current head 9e02c22 differs from pull request most recent head 479a09c. Consider uploading reports for the commit 479a09c to get more accurate results

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   87.25%   87.25%           
=======================================
  Files          48       48           
  Lines         816      816           
  Branches       97       97           
=======================================
  Hits          712      712           
  Misses         21       21           
  Partials       83       83           
Impacted Files Coverage Δ
...on-chrome/__tests__/helpers/mockPlatformService.ts 88.88% <0.00%> (ø)
packages/extension-chrome/src/services/config.ts 83.78% <ø> (ø)
packages/extension-chrome/src/rpc/walletImpl.ts 97.56% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@homura
Copy link
Contributor

homura commented Mar 13, 2023

it is ready for review?

@homura
Copy link
Contributor

homura commented Mar 13, 2023

BTW, can you help to remove favicons from the TrustedHost

@IronLu233 IronLu233 marked this pull request as ready for review March 13, 2023 12:41
@zhangyouxin
Copy link
Contributor

It would be great if some reference links are present in PR description so that I can understand how this PR works.

@homura homura mentioned this pull request Mar 24, 2023
@homura homura requested a review from zhangyouxin March 27, 2023 03:24
@homura homura added this to the 2023W13 milestone Mar 27, 2023
@IronLu233
Copy link
Contributor Author

BTW, can you help to remove favicons from the TrustedHost

We can't do it directly because it need a migration script to remove old config's favicon.

If we remove it directly, all modification with origin whitelist config will broken.
image

@homura homura added the patch Increment the patch version when merged label Mar 28, 2023
@homura homura merged commit 2211240 into ckb-js:main Mar 28, 2023
@IronLu233 IronLu233 deleted the favicon-url branch March 28, 2023 12:46
@github-actions
Copy link

🚀 PR was released in v0.0.6 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ico is wrong
3 participants