-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: disable unsafe any access #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 87.19% 87.36% +0.16%
==========================================
Files 48 48
Lines 812 815 +3
Branches 97 97
==========================================
+ Hits 708 712 +4
+ Misses 21 20 -1
Partials 83 83
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
homura
reviewed
Mar 24, 2023
packages/extension-chrome/src/services/ownership/backend/backendUtils.ts
Outdated
Show resolved
Hide resolved
homura
reviewed
Mar 28, 2023
packages/extension-chrome/src/services/ownership/backend/backendUtils.ts
Outdated
Show resolved
Hide resolved
homura
reviewed
Mar 28, 2023
homura
approved these changes
Mar 28, 2023
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Resolve #134 #138
add these ESlint rules. and disable some rules on unit test file.
Motivation
In our system we have some unsafe access, because they are from 3rd party library. In this PR, unless the developer use
as Type
first, they can not access the prop in the object.And for error catching, the developer must determine the error type, than can do the sequence thing.
Change Type
Indicate the type of change your pull request is:
documentation
internal
patch
minor
major