feat: sign data with a magic prefix for security #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 87.22% 87.25% +0.03%
==========================================
Files 48 48
Lines 814 816 +2
Branches 97 97
==========================================
+ Hits 710 712 +2
Misses 21 21
Partials 83 83
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@zhangyouxin can you help to resolve conflicts |
zhangyouxin
force-pushed
the
signdata-prefix
branch
from
69ee25b to
8fc0965
Compare
homura
reviewed
Mar 23, 2023
packages/extension-chrome/__tests__/services/ownership/fullOwnership.test.ts
Outdated
Show resolved
Hide resolved
packages/extension-chrome/__tests__/services/ownership/fullOwnership.test.ts
Outdated
Show resolved
Hide resolved
packages/extension-chrome/src/services/ownership/fullOwnership.ts
Outdated
Show resolved
Hide resolved
zhangyouxin
force-pushed
the
signdata-prefix
branch
from
b53c914 to
5631bbe
Compare
3 tasks
|
hi, @zhangyouxin, can you merge with main to avoid workflow failure |
homura
approved these changes
Mar 27, 2023
homura
changed the title
homura
added
the
breaking-minor
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
wallet_fullOwnership_signData()should be sign with [magic prefix bytes]Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor