Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension-chrome): fix typo and whitelist UI overflow #142

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

IronLu233
Copy link
Contributor

@IronLu233 IronLu233 commented Mar 23, 2023

What Changed

Motivation

Fix a typo: diposit -> deposit

and fix whitelist overflow on UI.

image
image

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

Copy link
Contributor

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #142 (7e382da) into main (39c5661) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files          48       48           
  Lines         814      814           
  Branches       97       97           
=======================================
  Hits          710      710           
  Misses         21       21           
  Partials       83       83           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@IronLu233 IronLu233 marked this pull request as ready for review March 23, 2023 10:42
@homura
Copy link
Contributor

homura commented Mar 23, 2023

I find the release is failed in release, but it is as expected. To avoid PR check failed, we should skip the canary release from a forked repo

@homura homura merged commit 2777ff8 into ckb-js:main Mar 23, 2023
@homura homura added the patch Increment the patch version when merged label Mar 23, 2023
@github-actions
Copy link

🚀 PR was released in v0.0.3 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants