Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e test #151
test: add e2e test #151
Changes from 15 commits
b2f45e9
4902575
b8427e2
3738671
d0db1f8
abd728a
fe55bc7
eae2b5a
b959551
f0c8f5b
7d6498e
737f6fd
061faa3
819de54
66354c0
7b7c2e5
3808ca8
2189b14
4293915
bbcebfb
cee0763
f15f075
8a86a68
819d795
5b3543a
68abe02
2604495
e57b061
e25dcdd
a768806
2dce2e5
90b3e20
4026e6b
a730145
90f61a9
66ae1b7
94d16f3
d6408cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a ENV property for the path
/home/runner/work/nexus/nexus
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path is the fixed path in the action, need to modify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The better way is to modify these rules. I have seen many
/* eslint-disable xxxxxxx */
in e2e. these rules may not suitable to enable on the e2e test files. @homura can we modify it? I need your opinion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only 12 disable mark in this PR, and I found no disable mark for
any
, therefore, just keep it as it isThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems it is not a test case, maybe a setup step for global.
Please use globalSetup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At that time, I made some adjustments in globalSetup, but it seemed that the Allure plugin had not been loaded yet, which resulted in an error. Therefore, I directly wrote it in the test case instead.