Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry not work in backend #167

Merged
merged 2 commits into from
Mar 28, 2023
Merged

fix: retry not work in backend #167

merged 2 commits into from
Mar 28, 2023

Conversation

zhangyouxin
Copy link
Contributor

What Changed

Motivation

This pr resolves: #159 and adds test case for refetch scenario.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@zhangyouxin zhangyouxin marked this pull request as ready for review March 28, 2023 14:23
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #167 (ad56928) into main (2211240) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   86.81%   86.79%   -0.02%     
==========================================
  Files          40       40              
  Lines         766      765       -1     
  Branches       94       94              
==========================================
- Hits          665      664       -1     
  Misses         20       20              
  Partials       81       81              
Impacted Files Coverage Δ
...ome/src/services/ownership/backend/backendUtils.ts 90.24% <100.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@homura homura changed the title [fix]: refetch bug fix: retry not work in backend Mar 28, 2023
@homura homura added the patch Increment the patch version when merged label Mar 28, 2023
@homura homura merged commit 749486c into ckb-js:main Mar 28, 2023
@github-actions
Copy link

🚀 PR was released in v0.0.7 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fake refetch logic in backendUtils
2 participants