Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension-chrome): enable for http and local site #174

Merged
merged 5 commits into from
Mar 30, 2023
Merged

Conversation

homura
Copy link
Contributor

@homura homura commented Mar 29, 2023

What Changes

Resolve #172

Motivation

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

nexus--canary.174.4555510584.zip

@homura homura added the patch Increment the patch version when merged label Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #174 (ab41618) into main (749486c) will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   86.79%   86.75%   -0.05%     
==========================================
  Files          40       41       +1     
  Lines         765      770       +5     
  Branches       94       95       +1     
==========================================
+ Hits          664      668       +4     
  Misses         20       20              
- Partials       81       82       +1     
Impacted Files Coverage Δ
packages/extension-chrome/src/utils/validate.ts 75.00% <75.00%> (ø)
packages/extension-chrome/src/services/config.ts 84.21% <100.00%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@homura homura added the skip-release Preserve the current version when merged label Mar 30, 2023
@homura homura merged commit cd79532 into main Mar 30, 2023
@homura homura deleted the enable-local-site branch March 30, 2023 08:51
@github-actions
Copy link

🚀 PR was released in v0.0.8 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enable_wallet] failed
3 participants