Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: example work with fullOwnership provider #178

Conversation

zhangyouxin
Copy link
Contributor

@zhangyouxin zhangyouxin commented Mar 30, 2023

What Changed

This PR has changed the transfer example from using RPC call to FullOwnershipProvider defined in #127

So that the base branch of this PR is ownership-provider

Motivation

To make transfer example more simple, and also some kind of testing FullOwnershipProvider, it's better that the transfer example uses FullOwnershipProvider to interact with Nexus Wallet

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

Note

Since that @nexus-wallet/ownership-provider has not been published to npm yet, this PR uses npm workspace to use the package.

@zhangyouxin zhangyouxin changed the title feat: example work with fullOwnership provider feat: example work with fullOwnership provider [WIP] Mar 30, 2023
@zhangyouxin zhangyouxin changed the title feat: example work with fullOwnership provider [WIP] [WIP]: example work with fullOwnership provider Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #178 (8c30318) into ownership-provider (cdd1710) will decrease coverage by 0.61%.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           ownership-provider     #178      +/-   ##
======================================================
- Coverage               87.23%   86.63%   -0.61%     
======================================================
  Files                      50       42       -8     
  Lines                     901      853      -48     
  Branches                  110      107       -3     
======================================================
- Hits                      786      739      -47     
  Misses                     21       21              
+ Partials                   94       93       -1     

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@homura homura deleted the branch ckb-js:ownership-provider April 10, 2023 02:29
@homura homura closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants