-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix incorrect coverage in code cov #269
Conversation
Codecov Report
@@ Coverage Diff @@
## main #269 +/- ##
===========================================
- Coverage 86.28% 74.80% -11.48%
===========================================
Files 47 61 +14
Lines 933 1401 +468
Branches 119 197 +78
===========================================
+ Hits 805 1048 +243
- Misses 24 329 +305
+ Partials 104 24 -80
... and 44 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I found that this 97.53% coverage is not real, we may need to define the |
# Conflicts: # packages/extension-chrome/public/manifest.json
# Conflicts: # packages/extension-chrome/public/manifest.json
🚀 PR was released in |
What Changed
Motivation
The clover report is a bit strange, there are always some partial covered that are not well understood, I would like to try other reports to avoid this problem
The PR reveals a more honest test coverage, so test coverage is reduced since the unit tests only covered the business code, the files like
PlatformService
can't be covered since it must run in a Chrome extension environment.According to this PR, I think we should
browser
API for testing, e.g.NotificationManager
,Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major