feat(ownership-provider): support payFee and signTransaction in sendTransaction
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homura
reviewed
Apr 27, 2023
homura
previously approved these changes
Apr 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 74.80% 75.88% +1.08%
==========================================
Files 61 62 +1
Lines 1401 1497 +96
Branches 197 216 +19
==========================================
+ Hits 1048 1136 +88
- Misses 329 337 +8
Partials 24 24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
homura
reviewed
Apr 28, 2023
There was a problem hiding this comment.
we should mark all these functions as @internal
homura
reviewed
Apr 28, 2023
|
|
||
| await provider.sendTransaction(txSkeleton); | ||
|
|
||
| expect(provider.payFee).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
This test made me realize that we should ban transactions with fees above a threshold, as this is usually the case with errors. We can do it in another issue
packages/ownership-providers/__tests__/FullOwnershipProvider.test.ts
Outdated
Show resolved
Hide resolved
homura
reviewed
Apr 28, 2023
packages/ownership-providers/__tests__/FullOwnershipProvider.test.ts
Outdated
Show resolved
Hide resolved
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note
The
sendTransactionis smarter now, we don't need to callprovider.payFeeandprovider.signTransactionmanually, just send itWhat Changed
Resolve #219
This PR make it is easier to use
FullOwnershipProvider#sendTransaction, now when callsendTransaction, payFee and sign will also be done if needed.Motivation
Please see #219 for more details.
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor🐤 Download canary assets:
nexus--canary.272.4869012901.zip
📦 Published PR as canary version:
0.0.19--canary.272.4869012901.0✨ Test out this PR locally via: