Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix release error in pipeline #276

Merged
merged 1 commit into from
May 4, 2023
Merged

chore: fix release error in pipeline #276

merged 1 commit into from
May 4, 2023

Conversation

IronLu233
Copy link
Contributor

@IronLu233 IronLu233 commented May 4, 2023 •
edited by homura
Loading

What Changed

Fix Pipeline Error on release.
This PR move npm run build:libs to husky from lint-staged.

Motivation

lint-staged pass /home/runner/work/nexus/nexus/packages/utils/src/env.ts to lerna command, and it throws this error:

✖ npm run build:libs:
ERR! lerna Unknown argument: /home/runner/work/nexus/nexus/packages/utils/src/env.ts

> @nexus-wallet/[email protected] build:libs
> lerna run build --ignore '@nexus-wallet/extension-chrome' /home/runner/work/nexus/nexus/packages/utils/src/env.ts

Indeed, lint stage is only for check files in git stage. npm run build:libs is just a preparing step before check files in stage.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

nexus--canary.276.4879071928.zip

📦 Published PR as canary version: 0.0.19--canary.276.4879071928.0

✨ Test out this PR locally via:

npm install @nexus-wallet/[email protected]
npm install @nexus-wallet/[email protected]
npm install @nexus-wallet/[email protected]
npm install @nexus-wallet/[email protected]
# or 
yarn add @nexus-wallet/[email protected]
yarn add @nexus-wallet/[email protected]
yarn add @nexus-wallet/[email protected]
yarn add @nexus-wallet/[email protected]

@IronLu233 IronLu233 added the minor Increment the minor version when merged label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #276 (8274b96) into main (79e2e14) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   75.88%   75.88%           
=======================================
  Files          62       62           
  Lines        1497     1497           
  Branches      216      216           
=======================================
  Hits         1136     1136           
  Misses        337      337           
  Partials       24       24

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@IronLu233 IronLu233 marked this pull request as ready for review May 4, 2023 04:32
@homura homura added internal Changes only affect the internal API and removed minor Increment the minor version when merged labels May 4, 2023
homura
homura approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@homura homura merged commit bc64adb into main May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

🚀 PR was released in v0.0.19 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homura homura homura approved these changes

Assignees
No one assigned
Labels
internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IronLu233 @homura