-
Notifications
You must be signed in to change notification settings - Fork 5
Enter will not break the quote if Shift is pressed #23
Conversation
I pushed a commit 3a74581, and Travis-ci raised an error because of "Cannot load browser BrowserStack_Edge". Then I reverted it (84096ad) but Travis-ci still refused it for the same reason. I am extremely confused because 84096ad and c7b6479, who is the last commit on master and has been passed by Travis-ci, have the same code. @Reinmar Could you do me a favor and look into this issue? |
That's because of https://github.com/ckeditor/ckeditor5-dev/issues/402. You can ignore this error for now. |
OK, all green after we fixed https://github.com/ckeditor/ckeditor5-dev/issues/402. |
Let's focus on the PR now.
|
Anyway, let's better understand the problem first and see if:
|
This reverts commit 84096ad.
It works now. Thanks for your help.
OK. I will open an issue for this future. |
The behaviour that you wanted to achieve:
Is exactly how it works on master now. So I'm closing this PR. Thanks! |
Suggested merge commit message (convention)
Feature: Enter with Shift will not break the quote. Closes #23 .
Reason
Quote with empty lines is allowed by default:
But I can't input an empty line in the quote directly because of that Enter key will break quote. So I add this future.
Additional information
DomEventData.domEvent
is an undocumented attribute, which may cause some problem in future.