This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Rename editor#pluginsReady event as editor.plugins#ready
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Jan 24, 2019
src/editor/editor.js
Outdated
| @@ -310,7 +297,8 @@ export default class Editor { | |||
| resolve( | |||
| editor.initPlugins() | |||
| .then( () => { | |||
| editor.fire( 'dataReady' ); | |||
| // Fire `data#ready` event manually as `data#init()` method is not used. | |||
| editor.data.fire( 'ready' ); | |||
There was a problem hiding this comment.
I think the whole Editor#create method should be removed since it is meaningless.
There was a problem hiding this comment.
It was removed in 60d06c3. Unless you meant some other place in the code (it's only used in tests now)?
pjasiun
reviewed
Jan 24, 2019
pjasiun
reviewed
Jan 24, 2019
pjasiun
reviewed
Jan 24, 2019
pjasiun
reviewed
Jan 24, 2019
Co-Authored-By: f1ames <[email protected]>
pjasiun
reviewed
Jan 28, 2019
pjasiun
reviewed
Jan 28, 2019
pjasiun
reviewed
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Introduced
editor.plugins#readyevent. Closes ckeditor/ckeditor5#1477.BREAKING CHANGE: The
editor#pluginsReadyevent was removed. Theeditor.plugins#readyevent has been introduced and should be used instead.Additional information
See ckeditor/ckeditor5#1477 for more details. This PR mostly covers renaming
pluginsReadyevent (but also necessary adjustments to newdata#readyevent). The second PR (renamingdataReadyevent) is ckeditor/ckeditor5-engine#1646.Created
ckeditor5branch with all the changes - https://github.com/ckeditor/ckeditor5/tree/t/1477.The list of related PRs in other repos which needed adjustments:
ckeditor5-autosave- Adjustments to newdata#readyevent ckeditor5-autosave#22ckeditor5-editor-balloon- Adjustments to newdata#readyevent ckeditor5-editor-balloon#27ckeditor5-editor-classic- Adjustments to newdata#readyevent ckeditor5-editor-classic#80ckeditor5-editor-decoupled- Adjustments to newdata#readyevent ckeditor5-editor-decoupled#26ckeditor5-editor-inline- Adjustments to newdata#readyevent ckeditor5-editor-inline#46ckeditor5-engine- Renameeditor#dataReadyevent aseditor.data#readyckeditor5-engine#1646ckeditor5-ui- Adjustments to newdata#readyevent ckeditor5-ui#464ckeditor5-paragraph- Adjustments to newdata#readyevent ckeditor5-paragraph#40