You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, the tool mixes the first two steps together (commit+push) and it also mixes publishing which is unsafe because for 5 minutes (according to https://gist.github.com/Reinmar/8ae3db219d385df06ccb94cd6d17cfd6) we have an incomplete release on npm. This also breaks builds CI because pushes to the repo start builds which try to install packages which are not yet installed on npm. But it's hard to prevent that.
The text was updated successfully, but these errors were encountered:
I know that the order you proposed is better for running tests on CI because everything will be already in place when we push to GH. However, it's risky too because the repository may reject the tags or something and that would be bad if everything is already on npm.
So, I wanted to change the order to the one I proposed.
However, after having second thought I understood that you're right. Nothing relies on the repositories. Peoples' projects rely on npm. So that's the first thing to get right. We can always force push and clean GH after that if something broke (which is unlikely anyway).
Fix: Changed order of commands executed by the release tool to optimize the time it takes from the first published package to the last. Closes #272. Closes #292.
Due to releasing packages one after another, the builds on CI might break and users' `npm install` commands might fail too. Now release tool will:
* do all commits (generate missing changelogs or/and update dependencies' versions),
* publish all packages on NPM (all packages will contain proper versions),
* do all pushes (CI will not crash because all versions are valid),
* make the GitHub releases.
This will ensure that the process takes minimum amount of time.
The process should look like this:
Right now, the tool mixes the first two steps together (commit+push) and it also mixes publishing which is unsafe because for 5 minutes (according to https://gist.github.com/Reinmar/8ae3db219d385df06ccb94cd6d17cfd6) we have an incomplete release on npm. This also breaks builds CI because pushes to the repo start builds which try to install packages which are not yet installed on npm. But it's hard to prevent that.
The text was updated successfully, but these errors were encountered: