Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark v43.0.1 as the @latest release #1057

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Mark v43.0.1 as the @latest release #1057

merged 1 commit into from
Jan 17, 2025

Conversation

pomek
Copy link
Member

@pomek pomek commented Jan 17, 2025

Suggested merge commit message (convention)

Internal: Updated the release_id property to point to the v43.0.1 tag.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pomek
Copy link
Member Author

pomek commented Jan 17, 2025

For future reference, I created a simple script for collecting the required field.

import assert from 'node:assert';
import { Octokit } from '@octokit/rest';

const token = ''; // Provide a GitHub token.

const owner = 'ckeditor';
const repo = 'ckeditor5-dev';
const tag = 'v43.0.1';

const octokit = new Octokit( {
	auth: `token ${ token }`
} );

const { data: { id } } = await octokit.request( 'GET /repos/{owner}/{repo}/releases/tags/{tag}', {
	owner,
	repo,
	tag,
	headers: {
		'X-GitHub-Api-Version': '2022-11-28'
	}
} )

const { data: { tag_name } } = await octokit.request( 'GET /repos/{owner}/{repo}/releases/{release_id}', {
	owner,
	repo,
	release_id: id,
	headers: {
		'X-GitHub-Api-Version': '2022-11-28'
	}
} );

try {
	assert.strictEqual( tag, tag_name );

	console.log( { id } );
} catch ( error ) {
	console.log( error );
}

@coveralls
Copy link

Coverage Status

coverage: 88.001%. remained the same
when pulling 6123aab on fix-release-id
into 29113b6 on master.

Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@pomek pomek merged commit d955364 into master Jan 17, 2025
7 checks passed
@pomek pomek deleted the fix-release-id branch January 17, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants