-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tools - monorepo #613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scripts are looking good for the most part, there's one issue that I found in release script though:
Editor builds after performing npm run release:bump-version
still contain outdated (previous) version.
TC:
- Clone
mlewand/ckeditor5#master
fork and open terminal there. - Link
@ckeditor/ckeditor5-dev-env
package, so that you're using branch from this PR., npm run release:bump-version
- Open
ckeditor5-merge/packages/ckeditor5-build-classic/sample/index.html
in your web browser. - Open javascript console and log
CKEDITOR_VERSION
variable.
Expected
New version is used (19.0.0).
Also ensure that proper the build also latest code, as I didn't verify this now.
Actual
Old version is used (18.0.0).
Also small UX thing: during the first use of Compared to previous packages build seemed to be stuck. After inspecting the changes I know now that it's because for builds we are are generating build package. I was wondering whether we can quickly/cheaply append something like " (builds will take a longer time… relax)"? |
https://github.com/ckeditor/ckeditor5/blob/master/scripts/release/update-utils-version.js#L12-L13 If we skip some steps of the release process, things must be done manually. |
packages/ckeditor5-dev-env/lib/release-tools/utils/getpackagestorelease.js
Outdated
Show resolved
Hide resolved
The tool does not know which scripts are being executed. We could add something like "echo Building..." to |
Ok, so no cheap solution here. That being said, we can simply document this in our release instructions and this will be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine 👌
Suggested merge commit message (convention)
Other: Adjusted release tools to handle single mono-repository architecture. Closes #606.