Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tools - monorepo #613

Merged
merged 7 commits into from
May 15, 2020
Merged

Release tools - monorepo #613

merged 7 commits into from
May 15, 2020

Conversation

pomek
Copy link
Member

@pomek pomek commented Apr 9, 2020

Suggested merge commit message (convention)

Other: Adjusted release tools to handle single mono-repository architecture. Closes #606.

@pomek pomek requested a review from mlewand April 9, 2020 09:42
@coveralls
Copy link

coveralls commented Apr 9, 2020

Coverage Status

Coverage decreased (-0.02%) to 89.386% when pulling 1835a7e on i/606 into 3a30b8f on master.

Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scripts are looking good for the most part, there's one issue that I found in release script though:

Editor builds after performing npm run release:bump-version still contain outdated (previous) version.

TC:

  1. Clone mlewand/ckeditor5#master fork and open terminal there.
  2. Link @ckeditor/ckeditor5-dev-env package, so that you're using branch from this PR.,
  3. npm run release:bump-version
  4. Open ckeditor5-merge/packages/ckeditor5-build-classic/sample/index.html in your web browser.
  5. Open javascript console and log CKEDITOR_VERSION variable.

Expected

New version is used (19.0.0).

Also ensure that proper the build also latest code, as I didn't verify this now.

Actual

Old version is used (18.0.0).

@mlewand
Copy link
Contributor

mlewand commented Apr 20, 2020

Also small UX thing: during the first use of npm run release:bump-version -- --dry-run I started to worry when the prompt was stuck for more than ~20s here:

Compared to previous packages build seemed to be stuck. After inspecting the changes I know now that it's because for builds we are are generating build package.

I was wondering whether we can quickly/cheaply append something like " (builds will take a longer time… relax)"?

@pomek
Copy link
Member Author

pomek commented Apr 21, 2020

there's one issue that I found in release script though

https://github.com/ckeditor/ckeditor5/blob/master/scripts/release/update-utils-version.js#L12-L13

If we skip some steps of the release process, things must be done manually.

@pomek
Copy link
Member Author

pomek commented May 13, 2020

I was wondering whether we can quickly/cheaply append something like " (builds will take a longer time… relax)"?

The tool does not know which scripts are being executed. We could add something like "echo Building..." to preversion hook in our builds.

@pomek pomek changed the base branch from monorepo to master May 14, 2020 10:29
@mlewand
Copy link
Contributor

mlewand commented May 15, 2020

The tool does not know which scripts are being executed. We could add something like "echo Building..." to preversion hook in our builds.

Ok, so no cheap solution here. That being said, we can simply document this in our release instructions and this will be fine.

@mlewand mlewand self-requested a review May 15, 2020 11:32
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust releasing tools to work with monorepo
3 participants