Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 51: Uncaught TypeError: Iterator result undefined is not an object #3737

Closed
Reinmar opened this issue Jun 1, 2016 · 8 comments · Fixed by ckeditor/ckeditor5-engine#1641
Assignees
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 1, 2016

Since Chrome 51 we've got these errors in couple of places in our code.

https://twitter.com/reinmarpl/status/737926748453670912

Apparently, there's something wrong with the new V8. We need a quick workaround to be able to continue working and we need to report this to the V8 team.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 1, 2016

As for the workaround (6a0e21f5) I've got two comments:

  1. ckeditor/ckeditor5-engine@6a0e21f#commitcomment-17693257
  2. We should leave comments in the code mentioning that this code is not optimal because of this issue. We can't be sure how long it will stay with us ;/

@szymonkups
Copy link
Contributor

I've added more changes according to your suggestions.

@szymonkups
Copy link
Contributor

It looks like delegating from one generator to iterable object throws in chrome v51:

'use strict';

const keys = getAttributeKeys();
for (let key of keys) {
    if (key === 'three') {
        break;
    }
    console.log(key);
}


function* getAttributeKeys() {
    yield* ['one', 'two', 'three'];
}

Delegating to another generator instead of array works ok.

@szymonkups
Copy link
Contributor

I reported this to v8 bug tracker https://bugs.chromium.org/p/v8/issues/detail?id=5057.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 6, 2016

Looks like the bug was fixed by V8 team: https://bugs.chromium.org/p/v8/issues/detail?id=5057#c18

We'll be able to revert our changes soon.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 16, 2016

Chrome 51 is out, so it may be worth to try reverting all the changes that we've made.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 16, 2016

Sorry, I can still reproduce the issue on the fiddle, so I guess Chrome 51 doesn't use that fixed V8 version yet.

@Reinmar
Copy link
Member Author

Reinmar commented Jan 21, 2019

Let's revert those changes :D

@Reinmar Reinmar assigned pomek and unassigned szymonkups Jan 21, 2019
Reinmar referenced this issue in ckeditor/ckeditor5-engine Jan 23, 2019
Internal: Reverted changes introduced due to the bug in Chrome@51. Closes #454.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants