Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge branch t/ckeditor5-engine/1555
Browse files Browse the repository at this point in the history
Internal: Use built-in factories of range, position and selection classes. Avoid importing things from the engine. See ckeditor/ckeditor5-engine#1555.
  • Loading branch information
Reinmar committed Nov 1, 2018
2 parents 7a7b1d5 + c3aa469 commit f91cd80
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
],
"dependencies": {
"@ckeditor/ckeditor5-core": "^11.0.1",
"@ckeditor/ckeditor5-ui": "^11.1.0",
"@ckeditor/ckeditor5-utils": "^11.0.0",
"@ckeditor/ckeditor5-engine": "^11.0.0",
"@ckeditor/ckeditor5-paragraph": "^10.0.3",
"@ckeditor/ckeditor5-theme-lark": "^11.1.0"
"@ckeditor/ckeditor5-theme-lark": "^11.1.0",
"@ckeditor/ckeditor5-ui": "^11.1.0",
"@ckeditor/ckeditor5-utils": "^11.0.0"
},
"devDependencies": {
"@ckeditor/ckeditor5-cloud-services": "^10.1.0",
"@ckeditor/ckeditor5-editor-classic": "^11.0.1",
"@ckeditor/ckeditor5-engine": "^11.0.0",
"@ckeditor/ckeditor5-enter": "^10.1.2",
"@ckeditor/ckeditor5-image": "^11.0.0",
"@ckeditor/ckeditor5-typing": "^11.0.1",
Expand Down
7 changes: 3 additions & 4 deletions tests/headingcommand.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import ModelTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/modeltesteditor';
import ParagraphCommand from '@ckeditor/ckeditor5-paragraph/src/paragraphcommand';
import HeadingCommand from '../src/headingcommand';
import Range from '@ckeditor/ckeditor5-engine/src/model/range';
import { setData, getData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';

const options = [
Expand Down Expand Up @@ -65,7 +64,7 @@ describe( 'HeadingCommand', () => {
model.change( writer => {
const ranges = [
...model.document.selection.getRanges(),
Range.createFromParentsAndOffsets( element, 3, element, 3 )
writer.createRange( writer.createPositionAt( element, 3 ) )
];
writer.setSelection( ranges );
} );
Expand All @@ -83,7 +82,7 @@ describe( 'HeadingCommand', () => {
const element = document.getRoot().getChild( 1 );

model.change( writer => {
writer.setSelection( Range.createIn( element ) );
writer.setSelection( writer.createRangeIn( element ) );
} );

expect( command.value ).to.be.false;
Expand All @@ -94,7 +93,7 @@ describe( 'HeadingCommand', () => {
const element = document.getRoot().getChild( 1 );

model.change( writer => {
writer.setSelection( Range.createIn( element ) );
writer.setSelection( writer.createRangeIn( element ) );

expect( command.value ).to.equal( modelElement );
command.refresh();
Expand Down

0 comments on commit f91cd80

Please sign in to comment.