Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No "tick" for selected option #2436

Closed
fredck opened this issue Mar 14, 2017 · 2 comments
Closed

No "tick" for selected option #2436

fredck opened this issue Mar 14, 2017 · 2 comments
Assignees
@oleq
Labels
package:heading type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 9

Comments

@fredck
Copy link
Contributor

fredck commented Mar 14, 2017

I know that in #2422 it has been decided to move ahead with "tick" + "blue background" for the selected option in the list.

I would propose removing the tick:

  • It's a duplication of the "blue background", being superfluous, therefore.
  • It creates an ugly padding on the left of the list.
  • The fewer UI elements, the better.
  • It's ugly :P
@Reinmar
Copy link
Member

Reinmar commented Mar 14, 2017

After seeing this live I agree with @fredck. Also, I liked the dropdown that you showed me @oleq yesterday – it used only a blue bg color.

@Reinmar
Copy link
Member

Reinmar commented Mar 14, 2017

Related issue: https://github.com/ckeditor/ckeditor5-heading/issues/63

@oleq oleq self-assigned this Mar 15, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-heading Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:heading labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:heading type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 9
Development

No branches or pull requests
4 participants
@Reinmar @fredck @oleq @mlewand