This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
force-pushed
the
t/ckeditor5-image/241
branch
from
July 25, 2019 09:40
0749561
to
32b0ade
Compare
…n a image's natural width/height.
… difficult here, as initMouseEvent floors cursor position.
…ntral or side aligned.
The purpose of it is to make sure that the resize wrapper/border aligns to around the resize host and not the entire widget.
…king in unit tests.
… dedicated for the resizing.
|
Rounding done. It indeed fixed the visual issue. |
…'t interfere with the image reszier. Also reused Rect utility to fetch dimensions.
…p few lines above.
Only one test is failing.
…igure in manual tests.
Added resizeUnit config, changed module of the ResizeImageCommand.
…the image resize feature.
OK, it seems that we've got it. There's a set of followups, but we can merge the functionality which is definitely already functional. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced image widget resizer. Closes ckeditor/ckeditor5#5167.
Additional information