Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Image resizer #298

Merged
merged 69 commits into from
Aug 19, 2019
Merged

Image resizer #298

merged 69 commits into from
Aug 19, 2019

Conversation

mlewand
Copy link
Contributor

@mlewand mlewand commented Jul 22, 2019

Suggested merge commit message (convention)

Feature: Introduced image widget resizer. Closes ckeditor/ckeditor5#5167.


Additional information

@mlewand mlewand force-pushed the t/ckeditor5-image/241 branch from 0749561 to 32b0ade Compare July 25, 2019 09:40
@Mgsy
Copy link
Member

Mgsy commented Aug 12, 2019

Resize doesn't work if there are images in neighbouring table cells.

bug_cke5

mlewand added 28 commits August 12, 2019 10:38
… difficult here, as initMouseEvent floors cursor position.
The purpose of it is to make sure that the resize wrapper/border aligns to around the resize host and not the entire widget.
@Reinmar
Copy link
Member

Reinmar commented Aug 14, 2019

  • Tests
    • [ML] Update tests after our recent changes.
    • [ML] Test with responsive images markup.
    • [ML] Verify that srcsetAttributeConverter() doesn't override our width.
  • Collaboration examples
    • [PK] Secure resizing for image disappearing during resizing
    • [PK] Use command
    • [PK] Disabling the command should disable the UI
  • Misc
    • [ML] Percentage values
    • Fix the table selection handler
    • [PK] Fix the img{width} being float and resizer width being int, which adds this ugly
    • [ML] Make sure building API docs doesn't throw; document the config option and the ImageResize class
    • [PK] Feature guide
    • [KT] Repeate testing
    • [KT] Make sure other browsers are tested
  • Followups
    • Handle ESC key ckeditor/ckeditor5-widget#98
    • Split ImageResize to ImageResizeEditing and ImageResizeUI ckeditor/ckeditor5-image#304
    • Improve resize cursor so that it is not overridden during the resize. ckeditor/ckeditor5-widget#100
    • Better detect centered images ckeditor/ckeditor5-widget#102
    • Review other bugs reported by Kacper here.
    • Complete API docs.
    • Rewrite automated tests (100% CC and proper tests for classes). ckeditor/ckeditor5-widget#101

@Reinmar
Copy link
Member

Reinmar commented Aug 14, 2019

Rounding done. It indeed fixed the visual issue.

@Reinmar
Copy link
Member

Reinmar commented Aug 19, 2019

OK, it seems that we've got it. There's a set of followups, but we can merge the functionality which is definitely already functional.

@Reinmar Reinmar merged commit ddcb1b3 into master Aug 19, 2019
@Reinmar Reinmar deleted the t/ckeditor5-image/241 branch August 19, 2019 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the image resize handler
3 participants