This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Make IndentBlock work regardless of editor plugins order. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking schema for registered elements should be done in afterInit call to prevent plugin ordering related bugs.
Reinmar
suggested changes
Oct 7, 2019
The schema extending rules must be done in afterInit and all core indent block behavior should be done during the init phase.
|
I think that now it makes more sense. |
oleq
reviewed
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Make IndentBlock work regardless of editor plugins order. Closes ckeditor/ckeditor5#2359.
Checking schema for registered elements should be done
in afterInit call to prevent plugin ordering related bugs.