Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Add missing return value for link postfixer #245

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Add missing return value for link postfixer #245

merged 1 commit into from
Aug 1, 2019

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Jul 31, 2019

Suggested merge commit message (convention)

Fix: Add missing return value for link postfixer. Closes ckeditor/ckeditor5#4856.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f1eb91e on t/241 into d6c45df on master.

@mlewand mlewand requested a review from jodator August 1, 2019 13:40
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering adding tests for this change but I can't think of anything not artificial. Other features don't test this. Hence merging this as is.

@jodator jodator merged commit 14e5803 into master Aug 1, 2019
@jodator jodator deleted the t/241 branch August 1, 2019 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link post fixer should retrun true if change something
3 participants